From dc3b3eaeb35520abaec1ee3a104253f91a14acde Mon Sep 17 00:00:00 2001 From: Ben Clayton Date: Tue, 26 Nov 2019 17:56:42 +0000 Subject: [PATCH] CMakeLists.txt: Disable MSVC warning from third_party `nlohmann/json` raises a `size_t` to `int` MSVC warning that will fail the build if `CPPDAP_WARNINGS_AS_ERRORS` is enabled. Given that this is not our code, the best we can do is to make an exception for this warning. --- CMakeLists.txt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 995e80a..b8eda57 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -98,7 +98,12 @@ function(cppdap_set_target_options target) # Disable specific, pedantic warnings if(MSVC) - target_compile_options(${target} PRIVATE "-D_CRT_SECURE_NO_WARNINGS") + target_compile_options(${target} PRIVATE + "-D_CRT_SECURE_NO_WARNINGS" + + # Warnings from nlohmann/json headers. + "/wd4267" # 'argument': conversion from 'size_t' to 'int', possible loss of data + ) endif() # Treat all warnings as errors