mewin/glm
1
0
Fork 0
Code Releases Activity

Fixed error: comparing floating point with == or != is unsafe

Browse Source
This commit is contained in:
Groove
2018-07-27 01:15:58 +02:00
parent 27b5ddff2b
commit 382d3c674d
6 changed files with 296 additions and 291 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test/core/core_func_geometric.cpp
View File

@@ -1,6 +1,7 @@
#include <glm/geometric.hpp>
#include <glm/trigonometric.hpp>
#include <glm/vector_relational.hpp>
#include <glm/gtc/epsilon.hpp>
#include <glm/ext/vector_relational.hpp>
#include <glm/gtc/vec1.hpp>
#include <limits>
@@ -130,14 +131,14 @@ namespace reflect
glm::vec2 A(1.0f,-1.0f);
glm::vec2 B(0.0f, 1.0f);
glm::vec2 C = glm::reflect(A, B);
Error += C == glm::vec2(1.0, 1.0) ? 0 : 1;
Error += glm::all(glm::equal(C, glm::vec2(1.0, 1.0), 0.0001f)) ? 0 : 1;
}
{
glm::dvec2 A(1.0f,-1.0f);
glm::dvec2 B(0.0f, 1.0f);
glm::dvec2 C = glm::reflect(A, B);
Error += C == glm::dvec2(1.0, 1.0) ? 0 : 1;
Error += glm::all(glm::equal(C, glm::dvec2(1.0, 1.0), 0.0001)) ? 0 : 1;
}
return Error;
@@ -154,14 +155,14 @@ namespace refract
float A(-1.0f);
float B(1.0f);
float C = glm::refract(A, B, 0.5f);
Error += glm::epsilonEqual(C, -1.0f, 0.0001f) ? 0 : 1;
Error += glm::equal(C, -1.0f, 0.0001f) ? 0 : 1;
}
{
glm::vec2 A(0.0f,-1.0f);
glm::vec2 B(0.0f, 1.0f);
glm::vec2 C = glm::refract(A, B, 0.5f);
Error += glm::all(glm::epsilonEqual(C, glm::vec2(0.0, -1.0), 0.0001f)) ? 0 : 1;
Error += glm::all(glm::equal(C, glm::vec2(0.0, -1.0), 0.0001f)) ? 0 : 1;
}
{