From 8e8d046587ac31123fe52ec1f2fe9c8367804d9c Mon Sep 17 00:00:00 2001 From: Groove Date: Sat, 28 Jul 2018 21:40:20 +0200 Subject: [PATCH] Fixed error: comparing floating point with == or != is unsafe --- test/gtx/gtx_extended_min_max.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/gtx/gtx_extended_min_max.cpp b/test/gtx/gtx_extended_min_max.cpp index e0dd08aa..3e0bb001 100644 --- a/test/gtx/gtx_extended_min_max.cpp +++ b/test/gtx/gtx_extended_min_max.cpp @@ -57,17 +57,17 @@ namespace fmax_ glm::vec2 B0 = glm::fmax(glm::vec2(1), glm::vec2(1)); glm::vec2 B1 = glm::fmax(glm::vec2(1), 1.0f); - bool B2 = glm::all(glm::equal(B0, B1)); + bool B2 = glm::all(glm::equal(B0, B1, glm::epsilon())); Error += B2 ? 0 : 1; glm::vec3 C0 = glm::fmax(glm::vec3(1), glm::vec3(1)); glm::vec3 C1 = glm::fmax(glm::vec3(1), 1.0f); - bool C2 = glm::all(glm::equal(C0, C1)); + bool C2 = glm::all(glm::equal(C0, C1, glm::epsilon())); Error += C2 ? 0 : 1; glm::vec4 D0 = glm::fmax(glm::vec4(1), glm::vec4(1)); glm::vec4 D1 = glm::fmax(glm::vec4(1), 1.0f); - bool D2 = glm::all(glm::equal(D0, D1)); + bool D2 = glm::all(glm::equal(D0, D1, glm::epsilon())); Error += D2 ? 0 : 1; return Error;