mewin/glslang
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix xfb stride limit issue (#2088)

Browse Source 
* Fix xfb_stride limit issue

Unsized array can't apply to transform trace. layout qualifier "offset" require GL_ARB_enhanced_layouts enable or glsl core version > 440.

* Add negative test for xfb limit

* update case result

* Fix compile information issue

Fix compile information issue and test comment issue.

* remove es profile condition, use profileRequires to limit.

* Fix xfb_stride limit issue

Unsized array can't apply to transform trace. layout qualifier "offset" require GL_ARB_enhanced_layouts enable or glsl core version > 440.
Add negative test for xfb limit

* Move es profile check out of version number check

* Adjust error information and related cases

remove the new version check, refine original version check.

* Revert condition for vulkan, and remove redundant test code.
This commit is contained in:
Roy.li
2020-06-09 16:30:14 +08:00
committed by GitHub
parent 8111268575
commit 08328fea5a
15 changed files with 294 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
Test/baseResults/xfbUnsizedArray.error.vert.out Normal file
View File

@@ -0,0 +1,69 @@
xfbUnsizedArray.error.vert
ERROR: 0:4: 'xfb_offset' : unsized array in buffer 0
ERROR: 1 compilation errors. No code generated.
Shader version: 430
Requested GL_ARB_enhanced_layouts
in xfb mode
ERROR: node is still EOpNull!
0:9 Function Definition: main( ( global void)
0:9 Function Parameters:
0:11 Sequence
0:11 Sequence
0:11 move second child to first child ( temp 4-component vector of float)
0:11 'result' ( temp 4-component vector of float)
0:11 'in_vs' ( in 4-component vector of float)
0:13 move second child to first child ( temp 4-component vector of float)
0:13 direct index (layout( xfb_buffer=0 xfb_offset=0) smooth temp 4-component vector of float)
0:13 'xfb_buffer' (layout( xfb_buffer=0 xfb_offset=0) smooth out unsized 1-element array of 4-component vector of float)
0:13 Constant:
0:13 0 (const int)
0:13 divide ( temp 4-component vector of float)
0:13 'result' ( temp 4-component vector of float)
0:13 Constant:
0:13 2.000000
0:15 move second child to first child ( temp 4-component vector of float)
0:15 'out_vs' ( smooth out 4-component vector of float)
0:15 'result' ( temp 4-component vector of float)
0:? Linker Objects
0:? 'xfb_buffer' (layout( xfb_buffer=0 xfb_offset=0) smooth out unsized 1-element array of 4-component vector of float)
0:? 'in_vs' ( in 4-component vector of float)
0:? 'out_vs' ( smooth out 4-component vector of float)
0:? 'gl_VertexID' ( gl_VertexId int VertexId)
0:? 'gl_InstanceID' ( gl_InstanceId int InstanceId)
Linked vertex stage:
Shader version: 430
Requested GL_ARB_enhanced_layouts
in xfb mode
ERROR: node is still EOpNull!
0:9 Function Definition: main( ( global void)
0:9 Function Parameters:
0:11 Sequence
0:11 Sequence
0:11 move second child to first child ( temp 4-component vector of float)
0:11 'result' ( temp 4-component vector of float)
0:11 'in_vs' ( in 4-component vector of float)
0:13 move second child to first child ( temp 4-component vector of float)
0:13 direct index (layout( xfb_buffer=0 xfb_offset=0) smooth temp 4-component vector of float)
0:13 'xfb_buffer' (layout( xfb_buffer=0 xfb_offset=0) smooth out 1-element array of 4-component vector of float)
0:13 Constant:
0:13 0 (const int)
0:13 divide ( temp 4-component vector of float)
0:13 'result' ( temp 4-component vector of float)
0:13 Constant:
0:13 2.000000
0:15 move second child to first child ( temp 4-component vector of float)
0:15 'out_vs' ( smooth out 4-component vector of float)
0:15 'result' ( temp 4-component vector of float)
0:? Linker Objects
0:? 'xfb_buffer' (layout( xfb_buffer=0 xfb_offset=0) smooth out 1-element array of 4-component vector of float)
0:? 'in_vs' ( in 4-component vector of float)
0:? 'out_vs' ( smooth out 4-component vector of float)
0:? 'gl_VertexID' ( gl_VertexId int VertexId)
0:? 'gl_InstanceID' ( gl_InstanceId int InstanceId)