mewin/glslang
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Temporarily disable spirv1.6 tests

Browse Source 
These tests will be re-enabled when a Vulkan version is released that
supports spirv1.6.

Fixes #2858
This commit is contained in:
Greg Fischer
2022-01-11 13:13:50 -07:00
parent 57e25195eb
commit 140a76a447
3 changed files with 38 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
gtests/Spv.FromFile.cpp
View File

@@ -69,7 +69,7 @@ using CompileVulkanToSpirvDeadCodeElimTest = GlslangTest<::testing::TestWithPara
using CompileVulkanToDebugSpirvTest = GlslangTest<::testing::TestWithParam<std::string>>;
using CompileVulkan1_1ToSpirvTest = GlslangTest<::testing::TestWithParam<std::string>>;
using CompileToSpirv14Test = GlslangTest<::testing::TestWithParam<std::string>>;
using CompileToSpirv16Test = GlslangTest<::testing::TestWithParam<std::string>>;
//using CompileToSpirv16Test = GlslangTest<::testing::TestWithParam<std::string>>;
using CompileOpenGLToSpirvTest = GlslangTest<::testing::TestWithParam<std::string>>;
using VulkanSemantics = GlslangTest<::testing::TestWithParam<std::string>>;
using OpenGLSemantics = GlslangTest<::testing::TestWithParam<std::string>>;
@@ -123,12 +123,14 @@ TEST_P(CompileToSpirv14Test, FromFile)
Target::Spv);
}
TEST_P(CompileToSpirv16Test, FromFile)
{
loadFileCompileAndCheck(GlobalTestSettings.testRoot, GetParam(),
Source::GLSL, Semantics::Vulkan, glslang::EShTargetUniversal, glslang::EShTargetSpv_1_6,
Target::Spv);
}
// TODO(greg-lunarg): Re-enable tests when Vulkan1.3 ClientTarget is available
//TEST_P(CompileToSpirv16Test, FromFile)
//{
// loadFileCompileAndCheck(GlobalTestSettings.testRoot, GetParam(),
// Source::GLSL, Semantics::Vulkan, glslang::EShTargetUniversal, glslang::EShTargetSpv_1_6,
// Target::Spv);
//}
// Compiling GLSL to SPIR-V under OpenGL semantics. Expected to successfully
// generate SPIR-V.
@@ -630,15 +632,15 @@ INSTANTIATE_TEST_SUITE_P(
);
// clang-format off
INSTANTIATE_TEST_SUITE_P(
Glsl, CompileToSpirv16Test,
::testing::ValuesIn(std::vector<std::string>({
"spv.1.6.conditionalDiscard.frag",
"spv.1.6.helperInvocation.frag",
"spv.1.6.specConstant.comp",
})),
FileNameAsCustomTestSuffix
);
//INSTANTIATE_TEST_SUITE_P(
// Glsl, CompileToSpirv16Test,
// ::testing::ValuesIn(std::vector<std::string>({
// "spv.1.6.conditionalDiscard.frag",
// "spv.1.6.helperInvocation.frag",
// "spv.1.6.specConstant.comp",
// })),
// FileNameAsCustomTestSuffix
//);
// clang-format off