GL_EXT_mesh_shader/SPV_EXT_mesh_shader implementation

Added following updates to GL_EXT_mesh_shader implementation:

1. Added SPIRV and GLSL test cases
2. Added checks to ensure NV and EXT mesh shader builtins cannot be used interchangeably.
3. Updated the language name by removing the postfix "NV" to MeshShader and TaskShader.
4. Added checks for grammar checking to comply with the spec.

5. Added gl_NumWorkGroups builtin to Mesh shader
6. Fixed data type of gl_PrimitiveLineIndicesEXT and gl_PrimitiveTriangleIndicesEXT
7. Added new constants to the resources table
8. Updates to handle new storage qualifier "taskPayloadSharedEXT"
9. Updated test cases by replacing "taskEXT" with storage qualifier "taskPayloadSharedEXT"

Addressed  Review comments
1. Fixed instruction description used by glslang disassembly.
2. Updated OpEmitMeshTasksEXT as per spec update
3. Fixed implementation that errors out if there are more then one taskPayloadSharedEXT varjables.
4. Fixed miscellaneous error logs and removed unwanted code.

SPIRV 1.6 related build failure fixes
- Update SPIRV header to 1.6
- Fix conflict wiht SPIRV 1.6 change, where localSizeId is used for execution mode for mesh/task shaders

Enable SPIRV generated for EXT_mesh_shader to be version 1.4

GL_EXT_mesh_shader: Add checks for atomic support and corresponding test cases
This commit is contained in:
Pankaj Mistry
2021-08-25 13:41:32 -07:00
parent 69ae9e7460
commit 228c67228a
52 changed files with 8937 additions and 4185 deletions

View File

@@ -630,6 +630,17 @@ INSTANTIATE_TEST_SUITE_P(
"spv.WorkgroupMemoryExplicitLayout.std140.comp",
"spv.WorkgroupMemoryExplicitLayout.std430.comp",
"spv.WorkgroupMemoryExplicitLayout.scalar.comp",
// SPV_EXT_mesh_shader
"spv.ext.meshShaderBuiltins.mesh",
"spv.ext.meshShaderRedeclBuiltins.mesh",
"spv.ext.meshShaderTaskMem.mesh",
"spv.ext.meshShaderUserDefined.mesh",
"spv.ext.meshTaskShader.task",
"spv.atomiAddEXT.error.mesh",
"spv.atomiAddEXT.task",
"spv.460.subgroupEXT.task",
"spv.460.subgroupEXT.mesh",
})),
FileNameAsCustomTestSuffix
);

View File

@@ -73,9 +73,9 @@ EShLanguage GetShaderStage(const std::string& stage)
} else if (stage == "rcall") {
return EShLangCallable;
} else if (stage == "task") {
return EShLangTaskNV;
return EShLangTask;
} else if (stage == "mesh") {
return EShLangMeshNV;
return EShLangMesh;
} else {
assert(0 && "Unknown shader stage");
return EShLangCount;