mewin/glslang
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Attempt to fix chromium builds

Browse Source 
It would seem that `glslang_sources` has a private dependency on `glslang_build_info`, so `glslang_validator` cannot transitively `#include` the generated `glslang/build_info.h` header.

Add `glslang_build_info` as a direct dependency to `glslang_validator`.
Also remove the duplicate dependency on `glslang_build_info` in `glslang_sources_common`

Note: This is a speculative fix as I can build Chromium fine without these changes.
Not sure what's different between these configs.
This commit is contained in:
Ben Clayton 2020-07-10 13:46:25 +01:00
parent 020397608e
commit 360ba05949
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BUILD.gn
View File

@ -242,7 +242,6 @@ template("glslang_sources_common") {
if (invoker.enable_opt) { if (invoker.enable_opt) {
deps += [ deps += [
":glslang_build_info",
"${spirv_tools_dir}:spvtools_opt", "${spirv_tools_dir}:spvtools_opt",
"${spirv_tools_dir}:spvtools_val", "${spirv_tools_dir}:spvtools_val",
] ]
@ -289,6 +288,7 @@ executable("glslang_validator") {
deps = [ deps = [
":glslang_default_resource_limits_sources", ":glslang_default_resource_limits_sources",
":glslang_sources", ":glslang_sources",
":glslang_build_info",
] ]
public_configs = [ ":glslang_hlsl" ] public_configs = [ ":glslang_hlsl" ]