From e5712a2549616f866a31853b98618a7b99666d58 Mon Sep 17 00:00:00 2001 From: qining Date: Fri, 20 May 2016 14:11:28 -0400 Subject: [PATCH 1/2] Fix the slow down in noContraction propagation --- glslang/MachineIndependent/propagateNoContraction.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/glslang/MachineIndependent/propagateNoContraction.cpp b/glslang/MachineIndependent/propagateNoContraction.cpp index dcb75711..c7f3bc3a 100644 --- a/glslang/MachineIndependent/propagateNoContraction.cpp +++ b/glslang/MachineIndependent/propagateNoContraction.cpp @@ -401,7 +401,8 @@ bool TSymbolDefinitionCollectingTraverser::visitBinary(glslang::TVisit /* visit } else { // For other binary nodes, still traverse the right node. current_object_.clear(); - return true; + node->getRight()->traverse(this); + return false; } return false; } From 507308b26d1a90c741db759e4c6d55cf8702e5f0 Mon Sep 17 00:00:00 2001 From: qining Date: Fri, 20 May 2016 14:30:38 -0400 Subject: [PATCH 2/2] remove redundant 'return false' --- glslang/MachineIndependent/propagateNoContraction.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/glslang/MachineIndependent/propagateNoContraction.cpp b/glslang/MachineIndependent/propagateNoContraction.cpp index c7f3bc3a..835f57f6 100644 --- a/glslang/MachineIndependent/propagateNoContraction.cpp +++ b/glslang/MachineIndependent/propagateNoContraction.cpp @@ -402,7 +402,6 @@ bool TSymbolDefinitionCollectingTraverser::visitBinary(glslang::TVisit /* visit // For other binary nodes, still traverse the right node. current_object_.clear(); node->getRight()->traverse(this); - return false; } return false; }