From 554c854143d590c8c1ca1fdc924fc987d60f19de Mon Sep 17 00:00:00 2001 From: John Kessenich Date: Wed, 26 Jun 2013 23:41:30 +0000 Subject: [PATCH] Fix preprocessor memory leak. git-svn-id: https://cvs.khronos.org/svn/repos/ogl/trunk/ecosystem/public/sdk/tools/glslang@22195 e7fa87d3-cd2b-0410-9028-fcbf551c1848 --- glslang/MachineIndependent/preprocessor/cpp.c | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/glslang/MachineIndependent/preprocessor/cpp.c b/glslang/MachineIndependent/preprocessor/cpp.c index 86a28fb5..82da285a 100644 --- a/glslang/MachineIndependent/preprocessor/cpp.c +++ b/glslang/MachineIndependent/preprocessor/cpp.c @@ -1032,24 +1032,26 @@ int MacroExpand(int atom, yystypepp* yylvalpp, int expandUndef) return 1; } + // no recursive expansions if (sym && sym->details.mac.busy) - return 0; // no recursive expansions + return 0; + + // not expanding of undefined symbols + if ((! sym || sym->details.mac.undef) && ! expandUndef) + return 0; in = (MacroInputSrc*)malloc(sizeof(*in)); memset(in, 0, sizeof(*in)); in->base.line = cpp->currentInput->line; in->base.name = cpp->currentInput->name; - if ((! sym || sym->details.mac.undef)) { - if (expandUndef) { - // push input - in->base.scan = zero_scan; - in->base.prev = cpp->currentInput; - cpp->currentInput = &in->base; + if ((! sym || sym->details.mac.undef) && expandUndef) { + // push input + in->base.scan = zero_scan; + in->base.prev = cpp->currentInput; + cpp->currentInput = &in->base; - return -1; - } else - return 0; + return -1; } in->base.scan = macro_scan;