Reorder initializer fields to match variable declaration order (or vice versa) for several class constructors.

This commit is contained in:
Alex Szpakowski 2017-01-08 18:21:17 -04:00
parent 844dd45db6
commit 5f316d9b17
6 changed files with 30 additions and 29 deletions

View File

@ -168,8 +168,8 @@ public:
struct TResolverAdaptor struct TResolverAdaptor
{ {
TResolverAdaptor(EShLanguage s, TIoMapResolver& r, TInfoSink& i, bool& e) TResolverAdaptor(EShLanguage s, TIoMapResolver& r, TInfoSink& i, bool& e)
: resolver(r) : stage(s)
, stage(s) , resolver(r)
, infoSink(i) , infoSink(i)
, error(e) , error(e)
{ {

View File

@ -139,22 +139,22 @@ class TVariable;
class TIntermediate { class TIntermediate {
public: public:
explicit TIntermediate(EShLanguage l, int v = 0, EProfile p = ENoProfile) : explicit TIntermediate(EShLanguage l, int v = 0, EProfile p = ENoProfile) :
source(EShSourceNone), language(l), profile(p), version(v), treeRoot(0), language(l), source(EShSourceNone), profile(p), version(v), treeRoot(0),
numEntryPoints(0), numErrors(0), numPushConstants(0), recursive(false), numEntryPoints(0), numErrors(0), numPushConstants(0), recursive(false),
invocations(TQualifier::layoutNotSet), vertices(TQualifier::layoutNotSet), inputPrimitive(ElgNone), outputPrimitive(ElgNone), invocations(TQualifier::layoutNotSet), vertices(TQualifier::layoutNotSet), inputPrimitive(ElgNone), outputPrimitive(ElgNone),
pixelCenterInteger(false), originUpperLeft(false), pixelCenterInteger(false), originUpperLeft(false),
vertexSpacing(EvsNone), vertexOrder(EvoNone), pointMode(false), earlyFragmentTests(false), depthLayout(EldNone), depthReplacing(false), blendEquations(0), vertexSpacing(EvsNone), vertexOrder(EvoNone), pointMode(false), earlyFragmentTests(false), depthLayout(EldNone), depthReplacing(false), blendEquations(0),
multiStream(false), xfbMode(false), xfbMode(false), multiStream(false),
#ifdef NV_EXTENSIONS
layoutOverrideCoverage(false),
geoPassthroughEXT(false),
#endif
shiftSamplerBinding(0), shiftSamplerBinding(0),
shiftTextureBinding(0), shiftTextureBinding(0),
shiftImageBinding(0), shiftImageBinding(0),
shiftUboBinding(0), shiftUboBinding(0),
autoMapBindings(false), autoMapBindings(false),
flattenUniformArrays(false), flattenUniformArrays(false),
#ifdef NV_EXTENSIONS
layoutOverrideCoverage(false),
geoPassthroughEXT(false),
#endif
useUnknownFormat(false) useUnknownFormat(false)
{ {
localSize[0] = 1; localSize[0] = 1;
@ -422,13 +422,6 @@ protected:
EShSource source; // source language, known a bit later EShSource source; // source language, known a bit later
std::string entryPointName; std::string entryPointName;
std::string entryPointMangledName; std::string entryPointMangledName;
unsigned int shiftSamplerBinding;
unsigned int shiftTextureBinding;
unsigned int shiftImageBinding;
unsigned int shiftUboBinding;
bool autoMapBindings;
bool flattenUniformArrays;
bool useUnknownFormat;
EProfile profile; EProfile profile;
int version; int version;
@ -463,6 +456,14 @@ protected:
bool geoPassthroughEXT; bool geoPassthroughEXT;
#endif #endif
unsigned int shiftSamplerBinding;
unsigned int shiftTextureBinding;
unsigned int shiftImageBinding;
unsigned int shiftUboBinding;
bool autoMapBindings;
bool flattenUniformArrays;
bool useUnknownFormat;
typedef std::list<TCall> TGraph; typedef std::list<TCall> TGraph;
TGraph callGraph; TGraph callGraph;

View File

@ -500,8 +500,8 @@ protected:
TPpContext* pp) TPpContext* pp)
: tInput(pp), : tInput(pp),
prologue_(prologue), prologue_(prologue),
includedFile_(includedFile),
epilogue_(epilogue), epilogue_(epilogue),
includedFile_(includedFile),
scanner(3, strings, lengths, names, 0, 0, true), scanner(3, strings, lengths, names, 0, 0, true),
prevScanner(nullptr), prevScanner(nullptr),
stringInput(pp, scanner) stringInput(pp, scanner)

View File

@ -272,9 +272,9 @@ TSymbolDefinitionCollectingTraverser::TSymbolDefinitionCollectingTraverser(
ObjectAccesschainSet* precise_objects, ObjectAccesschainSet* precise_objects,
std::unordered_set<glslang::TIntermBranch*>* precise_return_nodes) std::unordered_set<glslang::TIntermBranch*>* precise_return_nodes)
: TIntermTraverser(true, false, false), symbol_definition_mapping_(*symbol_definition_mapping), : TIntermTraverser(true, false, false), symbol_definition_mapping_(*symbol_definition_mapping),
precise_objects_(*precise_objects), current_object_(), precise_objects_(*precise_objects), precise_return_nodes_(*precise_return_nodes),
accesschain_mapping_(*accesschain_mapping), current_function_definition_node_(nullptr), current_object_(), accesschain_mapping_(*accesschain_mapping),
precise_return_nodes_(*precise_return_nodes) {} current_function_definition_node_(nullptr) {}
// Visits a symbol node, set the current_object_ to the // Visits a symbol node, set the current_object_ to the
// current node symbol ID, and record a mapping from this node to the current // current node symbol ID, and record a mapping from this node to the current
@ -616,9 +616,9 @@ class TNoContractionPropagator : public glslang::TIntermTraverser {
public: public:
TNoContractionPropagator(ObjectAccesschainSet* precise_objects, TNoContractionPropagator(ObjectAccesschainSet* precise_objects,
const AccessChainMapping& accesschain_mapping) const AccessChainMapping& accesschain_mapping)
: TIntermTraverser(true, false, false), remained_accesschain_(), : TIntermTraverser(true, false, false),
precise_objects_(*precise_objects), accesschain_mapping_(accesschain_mapping), precise_objects_(*precise_objects), added_precise_object_ids_(),
added_precise_object_ids_() {} remained_accesschain_(), accesschain_mapping_(accesschain_mapping) {}
// Propagates 'precise' in the right nodes of a given assignment node with // Propagates 'precise' in the right nodes of a given assignment node with
// access chain record from the assignee node to a 'precise' object it // access chain record from the assignee node to a 'precise' object it

View File

@ -56,8 +56,8 @@ class TReflectionTraverser;
class TObjectReflection { class TObjectReflection {
public: public:
TObjectReflection(const TString& pName, const TType& pType, int pOffset, int pGLDefineType, int pSize, int pIndex) : TObjectReflection(const TString& pName, const TType& pType, int pOffset, int pGLDefineType, int pSize, int pIndex) :
name(pName), type(pType.clone()), name(pName), offset(pOffset),
offset(pOffset), glDefineType(pGLDefineType), size(pSize), index(pIndex) { } glDefineType(pGLDefineType), size(pSize), index(pIndex), type(pType.clone()) { }
void dump() const { void dump() const {
printf("%s: offset %d, type %x, size %d, index %d, binding %d\n", printf("%s: offset %d, type %x, size %d, index %d, binding %d\n",
@ -81,7 +81,7 @@ protected:
return type->getQualifier().layoutBinding; return type->getQualifier().layoutBinding;
} }
TObjectReflection() : type(nullptr), offset(-1), glDefineType(-1), size(-1), index(-1) { } TObjectReflection() : offset(-1), glDefineType(-1), size(-1), index(-1), type(nullptr) { }
const TType* type; const TType* type;
}; };

View File

@ -58,14 +58,14 @@ HlslParseContext::HlslParseContext(TSymbolTable& symbolTable, TIntermediate& int
TParseContextBase(symbolTable, interm, parsingBuiltins, version, profile, spvVersion, language, infoSink, forwardCompatible, messages), TParseContextBase(symbolTable, interm, parsingBuiltins, version, profile, spvVersion, language, infoSink, forwardCompatible, messages),
contextPragma(true, false), contextPragma(true, false),
loopNestingLevel(0), annotationNestingLevel(0), structNestingLevel(0), controlFlowNestingLevel(0), loopNestingLevel(0), annotationNestingLevel(0), structNestingLevel(0), controlFlowNestingLevel(0),
inEntryPoint(false),
postEntryPointReturn(false), postEntryPointReturn(false),
limits(resources.limits), limits(resources.limits),
inEntryPoint(false),
entryPointOutput(nullptr), entryPointOutput(nullptr),
nextInLocation(0), nextOutLocation(0),
sourceEntryPointName(sourceEntryPointName),
builtInIoIndex(nullptr), builtInIoIndex(nullptr),
builtInIoBase(nullptr) builtInIoBase(nullptr),
nextInLocation(0), nextOutLocation(0),
sourceEntryPointName(sourceEntryPointName)
{ {
globalUniformDefaults.clear(); globalUniformDefaults.clear();
globalUniformDefaults.layoutMatrix = ElmRowMajor; globalUniformDefaults.layoutMatrix = ElmRowMajor;