Alejandro Piñeiro
0f66082d1d
ParseHelper: don't assign xfb_offset for struct members
...
This commit undoes the code on the commit "ParseHelper: assign
xfb_offset for struct members too" (commit
af8c1bdb161e4b2ddf019b61bdfca61f84cb1ca8), except the method renaming,
and updates the tests.
During the review of the implementation of Vulkan extension
VK_EXT_transform_feedback for the Linux Intel driver, it was pointed
that the Vulkan environment spec for SPIR-V only ever refers to block
or block members being decorated. It would be strange to not do the
same for OpenGL (ARB_gl_spirv). That would also fit better to what
GLSL does, where setting explicit xfb offsets for struct members is
not allowed.
FWIW, the original patch was proposed based on the fact that
ARB_gl_spirv is relying on OpenGL for how xfb offsets should be
assigned to members, and it was not clear (at least to me) which is
the responsible of such.
2019-01-31 17:09:30 +01:00
Michael Spang
d39c040df9
Port Unix/ossource.cpp to Fuchsia
...
Fuchsia has pthreads but doesn't have sys/resource.h and doesn't
implement pthread_cleanup_push().
ANGLE bug: 2475
2019-01-30 15:15:11 -05:00
baldurk
6a87400c14
Add missing override specifiers in virtual class
2019-01-30 17:29:46 +00:00
baldurk
332b173c82
Fix mismatched integer comparison (size_t/unsigned int vs int)
2019-01-30 17:29:44 +00:00
Jamie Madill
1a1651c6e9
Disable Clang extra semicolon warning.
...
Usually this warning is disabled by default. But when turned on Clang
complains about extra semicolons in Glslang headers. Turn this off for
now. See http://crbug.com/926235
2019-01-30 11:37:15 -05:00
John Kessenich
c9e03360e2
Merge pull request #1675 from nicebyte/ext_yuv_target
...
Add support for GL_EXT_YUV_target
2019-01-29 19:03:11 -08:00
John Kessenich
31fbc11f5d
Build: Remove extra commas in calling INSTANTIATE_TEST_SUITE_P.
...
Hopefully, this fixes the sudden new breakage with the bots.
2019-01-29 16:00:42 -07:00
John Kessenich
4c57640052
Merge pull request #1681 from baldurk/reflection-fixes
...
Reflection consistency changes & bugfixes
2019-01-29 13:20:05 -08:00
nicebyte
c28369b75f
Add support for GL_EXT_YUV_target
2019-01-29 13:17:47 -08:00
baldurk
90995f5dae
Update reflection offset consistently for structure members
...
* Previously the offset was only updated with EOpIndexDirectStruct, but we also
need to update it for the other index types into arrays, and when expanding an
aggregate reached after dereferencing.
2019-01-29 17:00:53 +00:00
baldurk
7e500c7b36
Add missing initialisation of counterIndex and stages in badReflection()
2019-01-29 14:10:04 +00:00
John Kessenich
544c039d26
HLSL: Fix #1679 : Add HLSL earlydepthstencil -> SPV EarlyFragmentTests.
2019-01-28 22:19:43 -07:00
John Kessenich
8dff52509e
Merge pull request #1677 from greg-lunarg/kg100
...
Update spirv-tools known-good.
2019-01-25 12:08:11 -08:00
Greg Fischer
7a02e15e1e
Update spirv-tools known-good.
2019-01-25 11:11:27 -07:00
John Kessenich
e4f7a1f367
Merge pull request #1676 from nsubtil/nsubtil/do-not-cache-lib-suffix
...
build: Do not cache debug library suffix
2019-01-25 10:02:42 -08:00
Nuno Subtil
424612c0e7
build: Do not cache debug library suffix
...
For nested project builds, writing CMAKE_DEBUG_POSTFIX into the cache
ends up affecting other projects. Caching this value doesn't seem to be
required in practice, so this change removes the cache tag.
2019-01-25 09:30:37 -08:00
John Kessenich
2cf6613a0d
Merge pull request #1674 from null77/fix-msvc-sign-warning
...
Suppress a MSVC cast warning in GN.
2019-01-24 09:48:54 -08:00
Jamie Madill
08fe88a94c
Suppress a MSVC cast warning in GN.
...
Also came up when using the BUILD.gn file with ANGLE.
ANGLE bug: 3088
2019-01-24 10:56:20 -05:00
John Kessenich
4930964683
Merge pull request #1672 from sparmarNV/NV-extension-checks
...
Add extension checks for NV block member builtins
2019-01-23 17:26:19 -08:00
John Kessenich
2b92158724
Merge pull request #1671 from null77/fix-chrome-clang-warning
...
Suppress inconsistent override warning in GN.
2019-01-23 17:24:45 -08:00
Sahil Parmar
6b9a28b9cb
Add extension checks for NV block member builtins
2019-01-23 16:24:32 -08:00
Jamie Madill
9706106ecd
Suppress inconsistent override warning in GN.
...
This came up when trying to roll the new glslang into Chromium.
ANGLE bug: 3088
2019-01-23 18:58:10 -05:00
John Kessenich
d9cee59afa
Merge pull request #1626 from KhronosGroup/extension-support
...
Infrastructure: Generalize and broaden per-variable extension checking.
2019-01-23 12:05:22 -08:00
John Kessenich
6a9df5f48f
Merge pull request #1664 from null77/support-angle
...
Fix a few GN build issues.
2019-01-21 18:22:49 -08:00
Hodgman
0bb89f5809
HLSL: Protect against some crashes
2019-01-21 18:21:11 -08:00
John Kessenich
4e06d7a2bb
Merge pull request #1663 from jeffbolznv/reference_vs_memorymodel
...
More precisely check for the qualifiers that enable the vulkan memory model for buffer references.
2019-01-20 08:43:06 -07:00
Jeff Bolz
e135a4897a
More precisely check for the qualifiers that enable the vulkan memory model for buffer references.
...
Not all memory qualifiers necessarily need the vulkan memory model, e.g. volatile/restrict that correspond to core SPIR-V features do not.
2019-01-20 00:59:38 -06:00
Jamie Madill
0ceaebcff9
Fix a few GN build issues.
...
* adds a source set for default resource limits to mirror CMake
* adds a target executable for the standalone validator
* fixes a missing warning
Allows ANGLE to use the integrated BUILD.gn instead of a custom one.
ANGLE bug: 3088
2019-01-18 17:01:46 -05:00
John Kessenich
493dee0ade
Merge pull request #1656 from amdrexu/bugfix
...
Fix xfb_stride incorrectness(#1654 )
2019-01-17 21:53:34 -07:00
John Kessenich
d9739794e9
Merge pull request #1662 from dneto0/fix-leak2
...
HLSL: Avoid leaking a shadow sampler struct
2019-01-17 06:29:41 +07:00
John Kessenich
7f2a87e58c
Merge pull request #1661 from dneto0/fix-leak
...
Avoid leaking name for counter buffer
2019-01-17 05:29:31 +07:00
David Neto
edadbed6fb
HLSL: Avoid leaking a shadow sampler struct
2019-01-16 17:04:58 -05:00
David Neto
806e0573da
Avoid leaking name for counter buffer
2019-01-16 10:44:31 -05:00
John Kessenich
4c096c52f8
Merge pull request #1658 from KhronosGroup/fix-name-loc-str
...
HLSL: Fix #1655 ; use "" for nullptr file names
2019-01-16 21:27:25 +07:00
John Kessenich
b2395e9ddf
HLSL: Fix #1655 ; use "" for nullptr file names. Needs test cases.
2019-01-16 16:07:51 +07:00
John Kessenich
d72f488cc6
Build: fix warnings. Fixes #1653 .
2019-01-16 14:55:37 +07:00
Rex Xu
75c5603ada
Fix xfb_stride incorrectness( #1654 )
...
Add int64 support in XFB. Change containsDouble to contains64BitType. Make
it more general.
2019-01-14 12:02:58 +08:00
John Kessenich
2898223375
Bump revision.
2019-01-11 15:07:04 +07:00
John Kessenich
dfaaf75a31
Merge pull request #1652 from gnl21/cmake-fix
...
Work around a CMake cross-compilation issue
2019-01-11 14:55:36 +07:00
John Kessenich
712cd6618d
Merge pull request #1647 from dneto0/update-known-good
...
Update SPIRV-Tools known good: relax Uconvert check
2019-01-09 19:33:44 -07:00
David Neto
c4d5ac6bfa
Update SPIRV-Tools known good: relax Uconvert check
...
Permit UConvert as an OpSpecConstantOp operation when
SPV_AMD_gpu_shader_int_16 is used.
2019-01-09 10:32:32 -05:00
John Kessenich
28be4543cd
Infrastructure: Generalize and broaden per-variable extension checking.
2019-01-09 22:21:22 +07:00
John Kessenich
5795f9e387
Merge pull request #1646 from dneto0/parens-warning
...
Parenthesize to avoid GCC warning
2019-01-09 06:01:21 -07:00
David Neto
b11b997d59
Parenthesize to avoid GCC warning
2019-01-08 18:57:03 -05:00
John Kessenich
69932ab47f
Merge pull request #1645 from KhronosGroup/dupe-accelstruct
...
Don't output duplicate OpTypeAccelerationStructureNV declarations
2019-01-08 09:39:32 +07:00
John Kessenich
344a03c034
Merge pull request #1644 from jeffbolznv/buffer_reference
...
GL_EXT_buffer_reference
2019-01-08 08:25:35 +07:00
Piers Daniell
3cf3f96292
Don't output duplicate TypeAccelerationStructureNV declarations
2019-01-07 14:17:44 -07:00
Jeff Bolz
9f2aec49e9
GL_EXT_buffer_reference
2019-01-07 12:36:13 -06:00
John Kessenich
d12fbc4c0c
SPV: Move to the latest header.
2019-01-07 23:52:34 +07:00
dan sinclair
e96fa717d3
Make sure source strings are terminated ( #1641 )
...
* Make sure source strings are terminated
The source strings may or may not have a null terminator. We need to
make sure we add one before outputting the source strings as we iterate
over the c-str looking for the null terminator.
* Review feedback
2019-01-07 23:47:37 +07:00