85244d7486
This PR only changes a few lines of code, but is subtle. In HLSL, comparison operators (<,>,<=,>=,==,!=) operate component-wise when given a vector operand. If a whole vector equality or inequality is desired, then all() or any() can be used on the resulting bool vector. This PR enables this change. Existing shape conversion is used when one of the two arguments is a vector and one is a scalar. Some existing HLSL tests had assumed == and != meant vector-wise instead of component-wise comparisons. These tests have been changed to add an explicit any() or all() to the test source. This verifably does not change the final SPIR-V binary relative to the old behavior for == and !=. The AST does change for the (now explicit, formerly implicit) any() and all(). Also, a few tests changes where they previously had the return type wrong, e.g, from a vec < vec comparison in hlsl.shapeConv.frag. Promotion of comparison opcodes to vector forms (EOpEqual->EOpVectorEqual) is handled in promoteBinary(), as is setting the proper vector type of the result. EOpVectorEqual and EOpVectorNotEqual are now accepted as either aggregate or binary nodes, similar to how the other operators are handled. Partial support already existed for this: it has been fleshed out in the printing functions in intermOut.cpp. There is an existing defect around shape conversion with 1-vectors, but that is orthogonal to this PR and not addressed by it.
Glslang Tests based on the Google Test Framework
This directory contains Google Test based test fixture and test cases for glslang.
Apart from typical unit tests, necessary utility methods are added into
the GlslangTests fixture to provide the ability to do
file-based integration tests. Various *.FromFile.cpp files lists names
of files containing input shader code in the Test/ directory. Utility
methods will load the input shader source, compile them, and compare with
the corresponding expected output in the Test/baseResults/ directory.
How to run the tests
Please make sure you have a copy of Google Test checked out under
the External directory before building. After building, just run the
ctest command or the gtests/glslangtests binary in your build directory.
The gtests/glslangtests binary also provides an --update-mode command
line option, which, if supplied, will overwrite the golden files under
the Test/baseResults/ directory with real output from that invocation.
This serves as an easy way to update golden files.