ef33ec0925
This PR handles implicit promotions for intrinsics when there is no exact match, such as for example clamp(int, bool, float). In this case the int and bool will be promoted to a float, and the clamp(float, float, float) form used. These promotions can be mixed with shape conversions, e.g, clamp(int, bool2, float2). Output conversions are handled either via the existing addOutputArgumentConversion function, which this PR generalizes to handle either aggregates or unaries, or by intrinsic decomposition. If there are methods or intrinsics to be decomposed, then decomposition is responsible for any output conversions, which turns out to happen automatically in all current cases. This can be revisited once inout conversions are in place. Some cases of actual ambiguity were fixed in several tests, e.g, spv.register.autoassign.* Some intrinsics with only uint versions were expanded to signed ints natively, where the underlying AST and SPIR-V supports that. E.g, countbits. This avoids extraneous conversion nodes. A new function promoteAggregate is added, and used by findFunction. This is essentially a generalization of the "promote 1st or 2nd arg" algorithm in promoteBinary. The actual selection proceeds in three steps, as described in the comments in hlslParseContext::findFunction: 1. Attempt an exact match. If found, use it. 2. If not, obtain the operator from step 1, and promote arguments. 3. Re-select the intrinsic overload from the results of step 2.
Glslang Tests based on the Google Test Framework
This directory contains Google Test based test fixture and test cases for glslang.
Apart from typical unit tests, necessary utility methods are added into
the GlslangTests fixture to provide the ability to do
file-based integration tests. Various *.FromFile.cpp files lists names
of files containing input shader code in the Test/ directory. Utility
methods will load the input shader source, compile them, and compare with
the corresponding expected output in the Test/baseResults/ directory.
How to run the tests
Please make sure you have a copy of Google Test checked out under
the External directory before building. After building, just run the
ctest command or the gtests/glslangtests binary in your build directory.
The gtests/glslangtests binary also provides an --update-mode command
line option, which, if supplied, will overwrite the golden files under
the Test/baseResults/ directory with real output from that invocation.
This serves as an easy way to update golden files.