From 144b348e072a78e8130ed0acc452c9f039a67bf2 Mon Sep 17 00:00:00 2001 From: John Bowler Date: Fri, 19 Jan 2024 11:07:42 -0800 Subject: [PATCH] Use --xfail for Adler32 check in pngtest-all The test always failed on systems with no support for zlib inflateValidate and on systems where the png_set_option setting was disabled, however pngtest-all succeeded because the failure was ignored. The latter is now fixed so the badadler.png check needs to use --xfail, not --relaxed. Signed-off-by: John Bowler --- tests/pngtest-all | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/pngtest-all b/tests/pngtest-all index ba621f376..6ff351703 100755 --- a/tests/pngtest-all +++ b/tests/pngtest-all @@ -20,7 +20,10 @@ TEST --strict "${srcdir}"/pngtest.png # Various crashers # Use --relaxed because some come from fuzzers that don't maintain CRCs TEST --relaxed "${srcdir}"/contrib/testpngs/crashers/badcrc.png -TEST --relaxed "${srcdir}"/contrib/testpngs/crashers/badadler.png +# Use --xfail because there is no reliable way of disabling these errors +# (Adler32 checking cannot be switched off on all builds and there is no +# provision for turning the other checks into warnings.) +TEST --xfail "${srcdir}"/contrib/testpngs/crashers/badadler.png TEST --xfail "${srcdir}"/contrib/testpngs/crashers/bad_iCCP.png TEST --xfail "${srcdir}"/contrib/testpngs/crashers/empty_ancillary_chunks.png for file in "${srcdir}"/contrib/testpngs/crashers/huge_*_chunk.png