From 209b3e4b79780c3182d2f1f45c6e37abefd5d965 Mon Sep 17 00:00:00 2001 From: John Bowler Date: Fri, 16 Mar 2012 07:14:01 -0500 Subject: [PATCH] [libpng16] Added output flushing to aid debugging under Visual Studio. This is necessary because the VS2010 output window otherwise simply loses the error messages on error (they weren't flushed to the window before the process exited, apparently!) --- ANNOUNCE | 8 ++++++-- CHANGES | 6 +++++- contrib/libtests/pngstest.c | 5 +++++ 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/ANNOUNCE b/ANNOUNCE index b69c62a92..faa48cd20 100644 --- a/ANNOUNCE +++ b/ANNOUNCE @@ -1,5 +1,5 @@ -Libpng 1.6.0beta18 - March 15, 2012 +Libpng 1.6.0beta18 - March 16, 2012 This is not intended to be a public release. It will be replaced within a few weeks by a public version or by another test version. @@ -298,7 +298,7 @@ Version 1.6.0beta17 [March 10, 2012] chunks could end up with a too-small windowBits value in the deflate header. -Version 1.6.0beta18 [March 15, 2012] +Version 1.6.0beta18 [March 16, 2012] Issue a png_benign_error() instead of png_warning() about bad palette index. In pngtest, treat benign errors as errors if "-strict" is present. Fixed an off-by-one error in the palette index checking function. @@ -306,6 +306,10 @@ Version 1.6.0beta18 [March 15, 2012] Revised example.c to put text strings in a temporary character array instead of directly assigning string constants to png_textp members. This avoids compiler warnings when -Wwrite-strings is enabled. + Added output flushing to aid debugging under Visual Studio. Unfortunately + this is necessary because the VS2010 output window otherwise simply loses + the error messages on error (they weren't flushed to the window before + the process exited, apparently!) Send comments/corrections/commendations to png-mng-implement at lists.sf.net (subscription required; visit diff --git a/CHANGES b/CHANGES index 5d6bf5773..40cebb7f0 100644 --- a/CHANGES +++ b/CHANGES @@ -4049,7 +4049,7 @@ Version 1.6.0beta17 [March 10, 2012] chunks could end up with a too-small windowBits value in the deflate header. -Version 1.6.0beta18 [March 15, 2012] +Version 1.6.0beta18 [March 16, 2012] Issue a png_benign_error() instead of png_warning() about bad palette index. In pngtest, treat benign errors as errors if "-strict" is present. Fixed an off-by-one error in the palette index checking function. @@ -4057,6 +4057,10 @@ Version 1.6.0beta18 [March 15, 2012] Revised example.c to put text strings in a temporary character array instead of directly assigning string constants to png_textp members. This avoids compiler warnings when -Wwrite-strings is enabled. + Added output flushing to aid debugging under Visual Studio. Unfortunately + this is necessary because the VS2010 output window otherwise simply loses + the error messages on error (they weren't flushed to the window before + the process exited, apparently!) Send comments/corrections/commendations to png-mng-implement at lists.sf.net (subscription required; visit diff --git a/contrib/libtests/pngstest.c b/contrib/libtests/pngstest.c index 8ac8bac88..d82671319 100644 --- a/contrib/libtests/pngstest.c +++ b/contrib/libtests/pngstest.c @@ -3374,6 +3374,9 @@ test_one_file(const char *file_name, format_list *formats, png_uint_32 opts, result = testimage(&image, opts, formats); freeimage(&image); + /* Ensure that stderr is flushed into any log file */ + fflush(stderr); + if (log_pass) { if (result) @@ -3384,6 +3387,8 @@ test_one_file(const char *file_name, format_list *formats, png_uint_32 opts, print_opts(opts); printf(" %s\n", file_name); + /* stdout may not be line-buffered if it is piped to a file, so: */ + fflush(stdout); } else if (!result)