mewin/libpng
1
0
Fork 0
mirror of https://git.code.sf.net/p/libpng/code.git synced 2025-07-10 18:04:09 +02:00
Code Issues Projects Releases Wiki Activity

[libng17] Suppressed bogus Coverity issues in pngrutil.c and pngwutil.c.

Browse Source
This commit is contained in:
Glenn Randers-Pehrson 2015-09-19 22:47:59 -05:00
parent 69f2152c0f
commit d555056b24
4 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ANNOUNCE
View File

@ -900,6 +900,7 @@ Version 1.7.0beta66 [September 20, 2015]
correction introduced significant errors if the app subsequently correction introduced significant errors if the app subsequently
did further corrections, only shown by using files with gAMA 1/1.52 in did further corrections, only shown by using files with gAMA 1/1.52 in
pngstest (John Bowler). pngstest (John Bowler).
Suppressed bogus Coverity issues in pngrutil.c and pngwutil.c.
Send comments/corrections/commendations to png-mng-implement at lists.sf.net Send comments/corrections/commendations to png-mng-implement at lists.sf.net
(subscription required; visit (subscription required; visit

1
CHANGES
View File

@ -5199,6 +5199,7 @@ Version 1.7.0beta66 [September 20, 2015]
correction introduced significant errors if the app subsequently correction introduced significant errors if the app subsequently
did further corrections, only shown by using files with gAMA 1/1.52 in did further corrections, only shown by using files with gAMA 1/1.52 in
pngstest (John Bowler). pngstest (John Bowler).
Suppressed bogus Coverity issues in pngrutil.c and pngwutil.c.
Send comments/corrections/commendations to png-mng-implement at lists.sf.net Send comments/corrections/commendations to png-mng-implement at lists.sf.net
(subscription required; visit (subscription required; visit

2
pngrutil.c
View File

@ -4159,8 +4159,10 @@ png_read_process_IDAT(png_structrp png_ptr)
/* This can be temporary; it verifies the invariants on how /* This can be temporary; it verifies the invariants on how
* png_inflate_IDAT updates the {next,avail}_out fields: * png_inflate_IDAT updates the {next,avail}_out fields:
*/ */
#ifndef __COVERITY__ /* Suppress bogus Coverity complaint */
debug(png_ptr->zstream.avail_out == 1-cb && debug(png_ptr->zstream.avail_out == 1-cb &&
png_ptr->zstream.next_out == cb + &png_ptr->next_filter); png_ptr->zstream.next_out == cb + &png_ptr->next_filter);
#endif
/* next_out points into png_struct, for security do this: */ /* next_out points into png_struct, for security do this: */
png_ptr->zstream.next_out = NULL; png_ptr->zstream.next_out = NULL;

5
pngwutil.c
View File

@ -1140,7 +1140,12 @@ png_save_int_31(png_structrp png_ptr, png_bytep buf, png_int_32 i)
* actually makes this error impossible, but this is safe. * actually makes this error impossible, but this is safe.
*/ */
{ {
#ifndef __COVERITY__
if (i >= 0 && i <= 0x7FFFFFFF) if (i >= 0 && i <= 0x7FFFFFFF)
#else
/* Supress bogus Coverity complaint */
if (i >= 0)
#endif
{ {
png_save_uint_32(buf, (png_uint_32)/*SAFE*/i); png_save_uint_32(buf, (png_uint_32)/*SAFE*/i);
return 1; return 1;