mewin/mijin2
1
0
Fork 0
Code Issues 2 Pull Requests Projects Releases Wiki Activity

Silenced some weird (very likely false-positive) clang-tidy warnings.

Browse Source
This commit is contained in:
Patrick 2024-08-18 12:24:37 +02:00
parent 66e319fb0d
commit d73fa25ed8
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source/mijin/async/coroutine.hpp
View File

@ -274,7 +274,7 @@ struct TaskPromise : impl::TaskReturn<typename TTraits::result_t, TaskPromise<TT
template<typename TResultOther>
auto await_transform(TaskBase<TResultOther> task) noexcept
{
MIJIN_ASSERT(loop_ != nullptr, "Cannot await another task outside of a loop!");
MIJIN_ASSERT(loop_ != nullptr, "Cannot await another task outside of a loop!"); // NOLINT(clang-analyzer-core.UndefinedBinaryOperatorResult)
auto future = delayEvaluation<TResultOther>(loop_)->addTask(std::move(task), &sharedState_->subTask); // hackidyhack: delay evaluation of the type of loop_ as it is only forward-declared here
return await_transform(future);
}

4
source/mijin/container/optional.hpp
View File

@ -35,7 +35,7 @@ struct OptionalStorage
std::uint8_t used = 0;
[[nodiscard]]
constexpr bool empty() const noexcept { return !used; }
constexpr bool empty() const noexcept { return !used; } // NOLINT(clang-analyzer-core.uninitialized.UndefReturn)
template<typename... TArgs>
constexpr void emplace(TArgs&&... args) noexcept
@ -111,7 +111,7 @@ template<typename TValue>
class Optional
{
private:
impl::OptionalStorage<TValue> storage_;
impl::OptionalStorage<TValue> storage_ = {};
public:
constexpr Optional() = default;
constexpr Optional(NullOptional) noexcept {}