mewin/nana
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix bug that large listbox not scrolling correctly(#324)

Browse Source
This commit is contained in:
Jinhao 2018-07-15 16:52:33 +08:00
parent 6add8868da
commit 8e546695d7
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
source/gui/widgets/scroll.cpp
View File

@ -99,12 +99,14 @@ namespace nana
//Check scroll_area to avoiding division by zero. //Check scroll_area to avoiding division by zero.
if (scroll_area) if (scroll_area)
metrics_.value = pos * value_max / scroll_area; metrics_.value = pos * (static_cast<double>(value_max) / scroll_area); //converting to double to avoid overflow.
if (metrics_.value < value_max) if (metrics_.value < value_max)
{ {
int selfpos = static_cast<int>(metrics_.value * scroll_area / value_max); //converting to double to avoid overflow.
int nextpos = static_cast<int>((metrics_.value + 1) * scroll_area / value_max); auto const px_per_value = static_cast<double>(scroll_area) / value_max;
int selfpos = static_cast<int>(metrics_.value * px_per_value);
int nextpos = static_cast<int>((metrics_.value + 1) * px_per_value);
if(selfpos != nextpos && (pos - selfpos > nextpos - pos)) if(selfpos != nextpos && (pos - selfpos > nextpos - pos))
++metrics_.value; ++metrics_.value;