Restrict uniform array flattening to sampler and texture arrays.

Previously the uniform array flattening feature would trigger on loose
uniform arrays of any basic type (e.g, floats).  This PR restricts it
to sampler and texture arrays.  Other arrays would end up in their own
uniform block (anonymous or otherwise).  (Atomic counter arrays might be an
exception, but those are not currently flattened).
This commit is contained in:
steve-lunarg 2016-09-29 08:43:22 -06:00
parent 21e7e32126
commit bc9b7656b7
2 changed files with 4 additions and 2 deletions

View File

@ -941,7 +941,7 @@ void usage()
" explicit bindings.\n"
" --amb synonym for --auto-map-bindings\n"
"\n"
" --flatten-uniform-arrays flatten uniform array references to scalars\n"
" --flatten-uniform-arrays flatten uniform texture & sampler arrays to scalars\n"
" --fua synonym for --flatten-uniform-arrays\n"
);

View File

@ -736,7 +736,9 @@ bool HlslParseContext::shouldFlattenUniform(const TType& type) const
return type.isArray() &&
intermediate.getFlattenUniformArrays() &&
qualifier == EvqUniform;
qualifier == EvqUniform &&
// Testing the EbtSampler basic type covers samplers and textures
type.getBasicType() == EbtSampler;
}
void HlslParseContext::flatten(const TSourceLoc& loc, const TVariable& variable)