mewin/glslang
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
4,152 Commits 1 Branch 0 Tags
Commit Graph

4152 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
ZhiqianXia
47a21828bd fix a typo 2021-02-25 15:37:40 +08:00
greg-lunarg
00c6d2d4a7
Merge pull request #2549 from jeremy-lunarg/hayes-2479 
Require fixed workgroup size declaration
 2021-02-24 16:56:10 -07:00
Jeremy Hayes
1c62806468 Require fixed workgroup size declaration 
Fix 2479.
 2021-02-24 14:49:31 -07:00
greg-lunarg
9801a9e42a
Merge pull request #2546 from proydakov/msvc-noexcept-fix 
Fixed msvc 2019 nmake noexcept build.
 2021-02-24 12:02:07 -07:00
Evgeny Proydakov
5f7228e785 Fixed msvc 2019 nmake noexcept build. 
By default cmake generates cxx_flags with /EHsc parameter.
I updated CMAKE_CXX_FLAGS string and removed /EHsc, also I added compile defenitions _HAS_EXCEPTIONS=0, it is mandatory for noexcept build with MSVC STL implementation.
Output files became smaller.

How to reproduce:

Visual Studio 2019 x64 command port

mkdir build-msvc2019
cd build-msvc2019
cmake -G"NMake Makefiles" -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_LIBDIR=install ..
nmake

CXX FLAGS BEFORE:

-- CMAKE_C_FLAGS:   /DWIN32 /D_WINDOWS /W3
-- CMAKE_CXX_FLAGS: /DWIN32 /D_WINDOWS /W3 /GR- /EHsc
-- CMAKE_CXX_FLAGS_DEBUG:   /MDd /Zi /Ob0 /Od /RTC1
-- CMAKE_CXX_FLAGS_RELEASE: /MD /O2 /Ob2 /DNDEBUG
-- ENABLE_RTTI:       OFF
-- ENABLE_EXCEPTIONS: OFF

OUTPUT SIZE BEFORE:

Build folder size: 61,8 MB (64 808 580 bytes)

GLSLANG SIZE BEFORE:

glslang.lib 22,7 MB (23 887 150 bytes)

CXX FLAGS AFTER:

-- CMAKE_C_FLAGS:   /DWIN32 /D_WINDOWS /W3
-- CMAKE_CXX_FLAGS: /DWIN32 /D_WINDOWS /W3 /GR-
-- CMAKE_CXX_FLAGS_DEBUG:   /MDd /Zi /Ob0 /Od /RTC1
-- CMAKE_CXX_FLAGS_RELEASE: /MD /O2 /Ob2 /DNDEBUG
-- ENABLE_RTTI:       OFF
-- ENABLE_EXCEPTIONS: OFF

OUTPUT SIZE AFTER:

Build folder size: 58,4 MB (61 331 179 bytes)

GLSLANG SIZE AFTER:

glslang.lib 21,6 MB (22 655 252 bytes)
 2021-02-24 11:08:57 +03:00
greg-lunarg
2e99822c14
Merge pull request #2537 from proydakov/fixed-cmake-warning 
Fixed cmake generation warning for regeneration project build files.
 2021-02-23 10:23:12 -07:00
Evgeny Proydakov
6332f80b2d Code review. Thx greg-lunarg for comments. 2021-02-23 17:14:42 +03:00
ZhiqianXia
53e0e6a56e Replace the old version math func with C++11 to 
prevent some presicion issue.

reference link:
https://www.cplusplus.com/reference/cmath/

Signed-off-by: ZhiqianXia <xzq0528@outlook.com>
 2021-02-23 10:00:25 +08:00
greg-lunarg
6f7a8ebf76
Merge pull request #2525 from ZhiqianXia/master 
Cannot specify atomic counter with location.
 2021-02-22 17:36:30 -07:00
greg-lunarg
c8b95db65e
Merge pull request #2540 from dgkoch/dgkoch_build_fix 
Fix warning in build
 2021-02-22 17:07:33 -07:00
greg-lunarg
5421877c38
Merge pull request #2543 from greg-lunarg/chg11.2.0 
Update CHANGES.md to 11.2.0 to sync with current tagging.
 2021-02-22 13:54:00 -07:00
Greg Fischer
82a37a3531 Update CHANGES.md to 11.2.0 to sync with current tagging. 2021-02-22 12:11:47 -07:00
Daniel Koch
d9b931e2e8 Fix warning in build 
glslang/MachineIndependent/SymbolTable.h:892:41: error: comparison of integers of
different signs: 'int' and 'const uint32_t' (aka 'const unsigned int') [-Werror,-Wsign-compare]
            uint64_t level = currentLevel() > MaxLevelInUniqueID ? MaxLevelInUniqueID : currentLevel();
                             ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~
1 error generated.
 2021-02-19 16:48:50 -05:00
Evgeny Proydakov
31d234c1da Fixed cmake generation warning for regeneration project build files. 
[BEFORE]:

% cmake ..
CMake Warning (dev) at CMakeLists.txt:35 (project):
  Policy CMP0048 is not set: project() command manages VERSION variables.
  Run "cmake --help-policy CMP0048" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  The following variable(s) would be set to empty:

    CMAKE_PROJECT_VERSION
    CMAKE_PROJECT_VERSION_MAJOR
    CMAKE_PROJECT_VERSION_MINOR
    CMAKE_PROJECT_VERSION_PATCH
This warning is for project developers.  Use -Wno-dev to suppress it.

-- No build type selected, default to Debug
-- Found PythonInterp: /usr/local/bin/python3 (found version "3.9")
-- Found PythonInterp: /usr/local/bin/python3 (found suitable version "3.9", minimum required is "3")
-- optimizer enabled
-- Google Mock found - building tests
-- Configuring done

[AFTER]:

% cmake ..
-- No build type selected, default to Debug
-- Google Mock was not found - tests based on that will not build
-- Configuring done
-- Generating done
 2021-02-19 02:18:17 +03:00
greg-lunarg
e56beaee73
Merge pull request #2536 from greg-lunarg/chg0 
Update CHANGES for 11.1.0
 2021-02-18 15:18:16 -07:00
Greg Fischer
ecd9bb202f Update CHANGES for 11.1.0 2021-02-18 12:04:17 -07:00
greg-lunarg
51b86c1a2b
Merge pull request #2532 from juliusikkala/master 
Pass environment through PreprocessDeferred
 2021-02-15 13:41:48 -07:00
greg-lunarg
b0f8a0c3ab
Merge pull request #2458 from ShchchowAMD/unique_id-fix 
Fix issue for new unique id system.
 2021-02-15 13:22:14 -07:00
Chow
93b400f267 Fix issue for new unique id system. Add level bits to help verifying symbols and split symbol tables. 
For intermediates rebuilding, now need manually amending level bits for redeclaring built-ins.
 2021-02-15 20:35:20 +08:00
Julius Ikkala
6274ec5c20 Pass environment through PreprocessDeferred 2021-02-14 14:24:17 +02:00
greg-lunarg
6ab923c69d
Merge pull request #2531 from greg-lunarg/kg116 
Update spirv-tools and spirv-header known good.
 2021-02-11 17:30:24 -07:00
Greg Fischer
6866807d6a Update spirv-tools and spirv-header known good. 
This is being done to allow Vulkan validation layers to pick up
the new differentiated error code support in spirv-tools for
GPU-AV.
 2021-02-11 15:36:28 -07:00
greg-lunarg
4afd691772
Merge pull request #2526 from proydakov/regression-python3-is-required-even-without-using-SPIRV-Tools 
Fixed issues 2496. Used option 4: parse_version.cmake to avoid python3 usage.
 2021-02-09 10:02:24 -07:00
Evgeny Proydakov
e3dab6f0d2 Code review. Thx ben-clayton for comments. 2021-02-09 12:14:52 +03:00
Evgeny Proydakov
05798c17fb Fixed issues 2496. Used option 4: parse_version.cmake to avoid python3 usage. 
https://github.com/KhronosGroup/glslang/issues/2496
 2021-02-09 12:14:52 +03:00
ZhiqianXia
5100efdfa9 Cannot specify atomic counter with location. 
Signed-off-by: ZhiqianXia <xzq0528@outlook.com>
 2021-02-09 09:42:48 +08:00
ZhiqianXia
29b2a08133 Cannot specify atomic counter with location. 
Signed-off-by: ZhiqianXia <xzq0528@outlook.com>
 2021-02-09 09:39:40 +08:00
ZhiqianXia
c8db4f437a Cannot specify atomic counter with location. 
Signed-off-by: ZhiqianXia <xzq0528@outlook.com>
 2021-02-07 17:20:14 +08:00
greg-lunarg
386b4fcb28
Merge pull request #2523 from dneto0/remove-stray-semi 
Remove useless semicolon
 2021-02-03 15:50:43 -07:00
David Neto
57e6a38f2a Remove useless semicolon 
The extra semicolon causes a build failure if warnings are turned up high, and
warnings-as-errors is on. (-Werror=extra-semi)
 2021-02-03 14:14:11 -05:00
greg-lunarg
5c4f421121
Merge pull request #2517 from glebm/fix-ubsan-localintermediate 
callGraph.push_front -> emplace_front to fix UBSAN
 2021-02-01 10:53:37 -07:00
greg-lunarg
6d68720cbb
Merge pull request #2512 from cmarcelo/GL_EXT_shared_memory_block 
Add support for GL_EXT_shared_memory_block
 2021-02-01 09:29:52 -07:00
Gleb Mazovetskiy
546f626c58 callGraph.push_front -> emplace_front to fix UBSAN 
UBSAN rightly complains on `push_front` here:

    glslang/MachineIndependent/localintermediate.h💯8: runtime error: load of value 160, which is not a valid value for type 'bool'
    #0 in glslang::TCall::TCall(glslang::TCall&&) glslang/MachineIndependent/localintermediate.h:100
    #1 in void __gnu_cxx::new_allocator<std::_List_node<glslang::TCall> >::construct<glslang::TCall, glslang::TCall>(glslang::TCall*, glslang::TCall&&) /usr/include/c++/10/ext/new_allocator.h:150
    #2 in void std::allocator_traits<std::allocator<std::_List_node<glslang::TCall> > >::construct<glslang::TCall, glslang::TCall>(std::allocator<std::_List_node<glslang::TCall> >&, glslang::TCall*, glslang::TCall&&) /usr/include/c++/10/bits/alloc_traits.h:512
    #3 in std::_List_node<glslang::TCall>* std::__cxx11::list<glslang::TCall, std::allocator<glslang::TCall> >::_M_create_node<glslang::TCall>(glslang::TCall&&) (...)
    #4 in void std::__cxx11::list<glslang::TCall, std::allocator<glslang::TCall> >::_M_insert<glslang::TCall>(std::_List_iterator<glslang::TCall>, glslang::TCall&&) /usr/include/c++/10/bits/stl_list.h:1911
    #5 in std::__cxx11::list<glslang::TCall, std::allocator<glslang::TCall> >::push_front(glslang::TCall&&) /usr/include/c++/10/bits/stl_list.h:1167
    #6 in glslang::TIntermediate::addToCallGraph(TInfoSink&, std::__cxx11::basic_string<char, std::char_traits<char>, glslang::pool_allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, glslang::pool_allocator<char> > const&) glslang/MachineIndependent/Intermediate.cpp:2860

What happens here:

1. TCall's bool fields are not initialized on construction.
2. `push_front` move the `TCall` passed into it.
3. The move constructor copies unitialized bool, which may have an
   out-of-range value.

What this fix does:

Calls `emplace_back` to ensure no copy/move constructor is called.

Fixes #2222
Refs #2112
 2021-01-30 16:06:08 +00:00
Caio Marcelo de Oliveira Filho
4bfbf62794 Add support for GL_EXT_shared_memory_block 
Uses SPV_KHR_workgroup_memory_explicit_layout.  Note that if
GL_EXT_scalar_block_layout is enabled, Workgroup blocks can also use
scalar layout.
 2021-01-29 11:23:05 -08:00
Caio Marcelo de Oliveira Filho
3785ddd59a Update known_good.json to pick up SPV_KHR_workgroup_memory_explicit_layout 
Also update the test expectations regarding validation accordingly and
the in-tree spirv.hpp copy.
 2021-01-29 11:22:22 -08:00
Caio Marcelo de Oliveira Filho
a38df83d3e Consider GL_EXT_scalar_block_layout when validating SPIR-V 
If GL_EXT_scalar_block_layout is requested by the shader, set the
option to allow scalar blocks in the SPIR-V validator.

Fix the existing tests using scalar layout to not expect "Validation
failed".

Fixes #2400.
 2021-01-28 14:11:24 -08:00
greg-lunarg
f7c43377f0
Merge pull request #2513 from jeffbolznv/missingcap 
Add missing capability when QueueFamily scope is used
 2021-01-28 10:40:45 -07:00
Jeff Bolz
bfd84a39f2 Add missing capability when QueueFamily scope is used 
Also, if this capability is added and the memory model is not
otherwise enabled by pragma, enable it as part of postprocessing.
 2021-01-27 13:14:34 -06:00
greg-lunarg
36df92e4a0
Merge pull request #2511 from alan-baker/GL_EXT_null_initializer 
Implement GL_EXT_null_initializer
 2021-01-26 12:05:11 -07:00
John Kessenich
c739e03748 Implement GL_EXT_null_initializer 
Adds null initializer syntax (empty braces)
Allows null initialization of shared variables
 2021-01-25 15:54:52 -05:00
greg-lunarg
6abdde3ce5
Merge pull request #2508 from corporateshark/master 
Fix missing enum values in the C-interface #2507
 2021-01-21 10:58:14 -07:00
Sergey Kosarevsky
a720028cdd Fix missing enum values in the C-interface #2507 2021-01-21 02:33:16 +03:00
greg-lunarg
9b4e82efb4
Merge pull request #2505 from ben-clayton/update-licnese-checker-cfg 
license-checker.cfg: Update rules
 2021-01-19 11:05:02 -07:00
greg-lunarg
5b7d68ca6b
Merge pull request #2504 from cdotstout/fuchsia-cmake 
Add CMake support for Fuchsia
 2021-01-19 10:59:05 -07:00
Ben Clayton
752028582f license-checker.cfg: Update rules 
The license classification rules in github.com/google/licensecheck have been updated.
 2021-01-18 12:27:00 +00:00
Craig Stout
17a83a9b33 Add CMake support for Fuchsia 2021-01-15 10:30:23 -08:00
greg-lunarg
3de5cfe50e
Merge pull request #2498 from dezinjob/fix-option-replacement-vs 
Fix option replacement when flags are empty
 2021-01-06 19:29:37 -07:00
greg-lunarg
480f6039e0
Merge pull request #2500 from jeremy-lunarg/hayes-2497 
Prevent HLSL input under OpenGL semantics
 2021-01-06 10:48:00 -07:00
greg-lunarg
f77085c307
Merge pull request #2499 from greg-lunarg/i2494 
Fix debugInfo test to target vulkan1.1 as intended
 2021-01-05 18:38:50 -07:00
Jeremy Hayes
b73afa8631 Prevent HLSL input under OpenGL semantics 
Fix #2497.
 2021-01-05 15:55:58 -07:00