mewin/mijin2
1
0
Fork 0
Code Issues 2 Pull Requests Projects Releases Wiki Activity

Use copies of strings for the cache instead of string_views. Apparently my assumption was wrong.

Browse Source
This commit is contained in:
Patrick 2023-12-19 22:41:40 +01:00
parent de07cf91bc
commit 83d3ce9f1f
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
source/mijin/types/name.cpp
View File

@ -8,9 +8,6 @@
#include <string> #include <string>
#include <vector> #include <vector>
// note: the implementation assumes that std::vector moves the strings on resize and that strings don't reallocate when moved
// while that should be the case for any sane STL implementation it may cause dangling pointers if it's not
namespace mijin namespace mijin
{ {
@ -52,9 +49,9 @@ static std::shared_mutex& getGlobalNamesMutex()
return mutex; return mutex;
} }
static std::unordered_map<std::string_view, std::size_t>& getLocalNameCache() static std::unordered_map<std::string, std::size_t>& getLocalNameCache()
{ {
static std::unordered_map<std::string_view, std::size_t> cache; static std::unordered_map<std::string, std::size_t> cache;
return cache; return cache;
} }