Shahbaz Youssefi
10a7137dc9
Fix UBSAN error with negating 0x8000'0000
...
Signed-off-by: Shahbaz Youssefi <ShabbyX@gmail.com>
2021-06-03 17:18:12 -04:00
Shahbaz Youssefi
cfdeeb842d
Fix OOB write in matrix constructor
...
In a matrix constructor that takes a number of components, as many
components as necessary must be taken, with the rest discarded, as GLSL
allows more components than necessary to be specified. For example, the
following:
mat4 m4 = mat4(v4, v4.yzwx, v4.zwx, v4.zwxy, v4.wxyz);
is equivalent to:
mat4 m4 = mat4(v4, v4.yzwx, v4.zwx, v4.zwxy, v4.w);
glslang takes the components from the constructor and builds the single
components of the matrix in a 2D array before constructing the matrix
itself. It however did not check for extra parameters and was thus
writing OOB to said 2D array. This is fixed in this change
Signed-off-by: Shahbaz Youssefi <shabbyx@gmail.com>
2021-06-03 13:42:57 -04:00
syntheticmagus
ec73737859
Add setters for true and false blocks of selection nodes, copying the pattern already used for the condition.
2021-05-28 18:24:59 -07:00
Greg Fischer
6bdcb4be34
Merge pull request #2651 from greg-lunarg/rel0
...
Add missing libs to release
2021-05-27 14:11:46 -06:00
Greg Fischer
3406857053
Add missing libs to release
...
GenericCodeGen, MachineIndependent and glslang-default-resource-limits
Fixes #2648
2021-05-26 16:20:35 -06:00
Greg Fischer
6fe560f74f
Merge pull request #2647 from greg-lunarg/arg2
...
Do true SPV type check for function array arg linkage
2021-05-20 13:45:51 -06:00
Greg Fischer
11c24e9adb
Do true SPV type check for function array arg linkage
...
Previous check was missing type difference between uniform array
actual arg with stride decoration and the formal arg without. Now
does logical or component-wise copy where needed.
Fixes #2637
2021-05-20 10:51:14 -06:00
Greg Fischer
e71278cc92
Merge pull request #2646 from johnstiles-google/parseconst
...
Fix mat4x2(scalar) constructor.
2021-05-18 11:00:08 -06:00
John Stiles
9724ee42df
Fix mat4x2(scalar) constructor.
2021-05-18 12:13:41 -04:00
ZhiqianXia
587261a817
Atomic memory function can only be used for shader storage block member or shared variable.
...
The glsl spec says:A shader will fail to compile if the value passed to the mem argument of an atomic memory function does not
correspond to a buffer or shared variable.
2021-05-15 00:13:43 +08:00
Greg Fischer
202c8abae0
Merge pull request #2641 from tgfrerer/fix_hlsl_function_error_msg
...
fix error message for hlslGrammar::acceptConstructor
2021-05-11 13:50:53 -06:00
Greg Fischer
d234552c30
Merge pull request #2634 from xantares/patch-1
...
Dont export inline TObjectReflection::getType()
2021-05-11 10:10:34 -06:00
tgfrerer
adfa0938a2
fix error message for hlslGrammar::acceptConstructor
...
Fix the error message for when an erroneous HLSL constructor statement
is detected.
Prior to this change, such error messages would not show correct file
path and line number information.
Additionally, update test data to account for updated error messages.
2021-05-11 09:42:11 +01:00
xantares
eaf2af6451
Dont export inline TObjectReflection::getType()
...
Fixes mingw build
Closes #2460
2021-05-08 10:37:37 +02:00
Greg Fischer
9431c53c84
Merge pull request #2632 from greg-lunarg/karl0
...
Fix arrays dimensioned with spec constant sized gl_WorkGroupSize
2021-05-07 10:09:17 -06:00
Greg Fischer
1464d036b8
Fix arrays dimensioned with spec constant sized gl_WorkGroupSize
2021-05-06 18:05:16 -06:00
Greg Fischer
41e39c615b
Merge pull request #2631 from godlikepanos/master
...
Add support for 64bit integer types and 64bit integer vector types to bitCount() builtin
2021-05-03 14:29:52 -06:00
Greg Fischer
186bccdd9f
Merge pull request #2629 from okuoku/silence-cygwin-warning
...
Set CMake policy CMP0054 to NEW to silence warning
2021-05-03 14:10:53 -06:00
Panagiotis Christopoulos Charitos
6113723e40
Add support for 64bit integer types and 64bit integer vector types to bitCount() builtin.
...
Fixes #2630
2021-05-03 14:26:11 +02:00
okuoku
4c09598526
Set CMake policy CMP0054 to NEW to silence warning
...
CMAKE_SYSTEM_NAME variable might evaluate to existing variable such as
CYGWIN. This setting also matches with SPIRV-Tools.
2021-05-02 03:49:05 +09:00
Greg Fischer
56b17b2f2d
Merge pull request #2621 from Rob2309/auto-sampled-textures-tests
...
Added usage hint for --auto-sampled-textures and added test cases
2021-04-27 11:36:07 -06:00
Robin Quint
4bf373e9a3
Improved usage hint
2021-04-27 16:06:06 +02:00
Greg Fischer
18eef33bd7
Merge pull request #2624 from greg-lunarg/v011004000
...
Update CHANGES for 11.4.0
2021-04-23 02:16:52 -06:00
Greg Fischer
4e83d93b62
Update CHANGES for 11.4.0
2021-04-22 18:09:42 -06:00
Greg Fischer
4d658bd5d9
Merge pull request #2623 from greg-lunarg/except
...
Fix CMakeLists.txt to keep compatibility with CMake 3.10.2
2021-04-22 18:03:36 -06:00
Greg Fischer
7b51e234fe
Fix CMakeLists.txt to keep compatibility with CMake 3.10.2
2021-04-22 16:30:17 -06:00
Robin Quint
e50b0a857c
Added usage hint for --auto-sampled-textures, added test cases
2021-04-22 13:13:38 +02:00
Greg Fischer
25dd807c3a
Merge pull request #2620 from greg-lunarg/v011003000
...
Update CHANGES for 11.3.0
2021-04-21 22:58:39 -06:00
Greg Fischer
bc685667a7
Merge pull request #2619 from greg-lunarg/kg117
...
Update spirv-tools and spirv-headers known good
2021-04-21 22:57:06 -06:00
Greg Fischer
a6674e0120
Update CHANGES for 11.3.0
2021-04-21 18:42:12 -06:00
Greg Fischer
f90377e74a
Update spirv-tools and spirv-headers known good
2021-04-21 18:33:46 -06:00
Greg Fischer
7f46558b8c
Merge pull request #2616 from Rob2309/standalone-hlsl-sampled-textures
...
Exposed #856 as --hlsl-sampled-textures in the StandAlone
2021-04-21 18:17:42 -06:00
Greg Fischer
ebfca6099f
Change --hlsl-sampled-textures to --auto-sampled-textures
2021-04-21 16:49:53 -06:00
Greg Fischer
5bce773574
Merge pull request #2618 from DadSchoorse/depfile
...
Add a --depfile option in Standalone mode
2021-04-21 11:47:00 -06:00
Georg Lehmann
498d74d84c
Add some basic --depfile tests
2021-04-20 18:12:39 +02:00
Georg Lehmann
f050209ce1
Add a --depfile option.
...
The output is similar to gcc -MMD and can be used by build systems
like meson to automatically recompile shaders if an included header
was changed.
2021-04-20 18:09:56 +02:00
Robin Quint
219b7b9f72
Exposed #856 as --hlsl-sampled-textures in the StandAlone
2021-04-20 07:58:36 +02:00
Greg Fischer
60ce877de0
Merge pull request #2609 from ZhiqianXia/Feature2
...
TextureOffset not support sampler2DArrayShadow sampler until 430.
2021-04-19 12:03:05 -06:00
Greg Fischer
8427437221
Merge pull request #2614 from ZaOniRinku/master
...
Typo in ShaderLang.h
2021-04-19 11:03:39 -06:00
Greg Fischer
12f3eb8e3f
Fix and enable textureOffset_samper2darrayshadow test
2021-04-19 09:37:45 -06:00
ZaOniRinku
b67b6b359b
Fix typo in ShaderLang.h
2021-04-19 09:15:36 +02:00
Greg Fischer
ed948c8e12
Merge pull request #2612 from greg-lunarg/explicit0
...
Fix builtins for GL_EXT_shader_explicit_arithmetic_types for es
2021-04-16 17:42:16 -06:00
Greg Fischer
100457e095
Add missing builtins for GL_EXT_explicit_arithmetic_types for es
2021-04-16 15:39:11 -06:00
ZhiqianXia
41992e432c
TextureOffset not support sampler2DArrayShadow sampler until 430.
...
Signed-off-by: ZhiqianXia <xzq0528@outlook.com>
2021-04-15 21:38:35 +08:00
Greg Fischer
b3859343a2
Merge pull request #2602 from jeremy-lunarg/hayes-2514
...
Issue error when declaration rule fails
2021-04-14 16:24:38 -06:00
Greg Fischer
e7e4a8eecb
Merge pull request #2522 from dneto0/intlog2
...
Add IntLog2 and use it
2021-04-14 15:16:04 -06:00
David Neto
fa6e3c2737
Add IntLog2 and use it
...
Replace uses of floating point log2 when we want an integer result from
an integer operand. This avoids concerns about accuracy of floating
point library functions.
2021-04-13 14:09:44 -06:00
Greg Fischer
e6a0e7fc76
Merge pull request #2606 from greg-lunarg/semifix0
...
Get rid of extra semicolon causing gcc 10.3 troubles.
2021-04-13 10:16:50 -06:00
Greg Fischer
310a514717
Get rid of extra semicolon causing gcc 10.3 troubles.
2021-04-12 18:12:58 -06:00
Greg Fischer
a7f846a86c
Merge pull request #2601 from masterleming/always-install-resource-limits
...
Removed condition for glslang-default-resource-limits instalation.
2021-04-12 17:04:48 -06:00